Re: [libvirt] [PATCH v7 14/23] backup: Parse and output backup XML

On 3/27/19 7:05 AM, Peter Krempa wrote: Yeah, I need to patch that up. For the latest version of the XML documentation, I added <disk checkpoint='no'> with a comment that anything other than 'no' is informative, then wired the RNG to let it actually be a state machine ('begin', 'exported', 'ready', ...) tracking the various phases of which QMP commands have been issued (and therefore which commands have to be done in reverse for cleanup regardless of whether cleanup is full after success or partial after early failure). But I haven't finished wiring that through checkpoint_conf.c or through the later patches; at the moment, the later patches have some rather awkward hacks on checking if def->disks[i]->src is NULL (no disk image associated, so must be a disk not involved in the snapshot), vs. a separate state in def->disks[i]->state; but if I can properly unify that, I think it will be easier to manage. May be followup patches. Hence the 'internal' flag; this is ONLY supposed to be output for qemu's internal storage to /var/lib/libvirt/qemu/domain.xml to persist state across libvirtd restarts. I also think that by the end of my series, I was trying to avoid this ever landing on disk, and instead teaching libvirt to re-parse current node names from QMP on the fly before any operation where the node names are not still in memory from an earlier time. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org