Re: [libvirt] [libvirt-glib PATCHv2 4/5] gobject: Add wrapper for virNetworkDHCPLease
On Tue, Jun 30, 2015 at 01:25:28PM +0100, Zeeshan Ali (Khattak) wrote:
On Tue, Jun 30, 2015 at 12:41 PM, Christophe Fergeau
<cfergeau(a)redhat.com> wrote:
> Hey,
>
> Looks good to me, I'd name the type GVirNetworkDhcpLease rather than
> GVirNetworkDHCPLease, this is consistent with
> GVirConfigCapabilitiesCpuModel (and not CPUModel).
Hm.. I was trying to keep it consistent with the underlying
'virNetworkDHCPLease'.
I know, I'd favour consistency in the libvirt-glib API.
> Maybe more descriptive doc for some of the fields (client id, iaid, ...)
> could be useful? Or are they just obvious for someone familiar with
> dhcp?
I mostly copied those docs from libvirt docs. I myself don't
know/remember what those are. :) But I guess if someone using this API
is reading those, they'd know what they are or find out.
Fwiw, I find libvirt documentation to be a bit more explicit.. (in
virNetworkGetDHCPLeases ).
Just realized now, but wouldn't we be better off with
gvir_network_dhcp_lease_get_client_id;
gvir_network_dhcp_lease_get_expiry_time;
instead of
gvir_network_dhcp_lease_get_clientid;
gvir_network_dhcp_lease_get_expirytime;
?
Attachments:
- attachment.sig (application/pgp-signature — 819 bytes)