Re: [libvirt] [PATCH] qemu: fix QEMU_CAPS_NO_ACPI detection

On 12/21/12 15:07, Li Zhang wrote: > On Fri, Dec 21, 2012 at 9:38 PM, Ján Tomko <jtomko(a)redhat.com > <mailto:jtomko@redhat.com>> wrote: > In commit c4bbaaf8, caps->arch was checked uninitialized, rendering the > whole check useless. > This patch moves the conditional setting of QEMU_CAPS_NO_ACPI to > qemuCapsInitQMP, and removes the no longer needed exception for S390. > Will it get QEMU_CAPS_NO_ACPI capability by QMP if S390 doesn't support > ACPI? > I test it on PPC, it won't get this capability by QMP. > Thanks. No, QEMU_CAPS_NO_ACPI capability will only be set on i686 and x86_64.