Re: [libvirt] [PATCH] test: snapshots: Fix some unused variables

Spotted by coverity as John mentioned here: http://www.redhat.com/archives/libvir-list/2013-October/msg00078.html --- src/test/test_driver.c | 24 ++---------------------- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 255cc2b..a09facb 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -6547,16 +6547,12 @@ testDomainSnapshotIsCurrent(virDomainSnapshotPtr snapshot, { virDomainObjPtr vm = NULL; int ret = -1; - virDomainSnapshotObjPtr snap = NULL; virCheckFlags(0, -1); if (!(vm = testDomObjFromSnapshot(snapshot))) goto cleanup; - if (!(snap = testSnapObjFromSnapshot(vm, snapshot))) - goto cleanup;

@@ -6568,27 +6564,11 @@ cleanup: static int -testDomainSnapshotHasMetadata(virDomainSnapshotPtr snapshot, +testDomainSnapshotHasMetadata(virDomainSnapshotPtr snapshot ATTRIBUTE_UNUSED, unsigned int flags) { - virDomainObjPtr vm = NULL; - int ret = -1; - virDomainSnapshotObjPtr snap = NULL; - virCheckFlags(0, -1); - - if (!(vm = testDomObjFromSnapshot(snapshot))) - goto cleanup; - - if (!(snap = testSnapObjFromSnapshot(vm, snapshot))) - goto cleanup;