Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable
Ivan Mishonov wrote:
Yes, that makes sense. I'll try to find some time next week to
redo my
code and send another patch. Since my time for working on libvirt is
very limited can you confirm that the LPC configuration should look like
this:
<controller type="isa-bridge" index="0">
<address type="pci" domain="0" bus="0"
slot="NNN" function="0"/>
</controller>
This looks reasonable to me. However, it adds some corner cases we need to
handle:
1. I'm wondering if we should still default to 31 if this entry is not specified?
We can generate this entry when post-processing XML, but I'm not sure
what's the best way to handle upgrades for the existing domains...
2. According to bhyve(8) manual page, lpc is only supported on bus 0, so
need to add 'isa-bridge' specific validation to check that.
Roman Bogorodskiy
Attachments:
- signature.asc (application/pgp-signature — 455 bytes)