Andrea Bolognani wrote:
On Tue, 2015-10-27 at 14:54 +0300, Roman Bogorodskiy wrote:
> > Weak ACK -- I have nowhere to try it and I'm lazy to install such
> > machine just for trying out this patch, but I can clearly see it
> > won't
> > break anything that works right now, so...
>
> FWIW, it also looks fine to me (though I do not have GNU\kFreeBSD
> boxes
> as well, only FreeBSD ones). I can build-test on FreeBSD just to be
> on a
> safe side, but it doesn't seem like it could break something indeed.
I'd like to point out that FreeBSD builds are now performed
regularly, so any breakage affecting FreeBDS should be detected
pretty quickly.
https://ci.centos.org/view/libvirt-project/job/libvirt-freebsd/
Cheers.
That's great!
Actually, I have Jenkins job configured for a while now. It simply pulls
sources from the github mirror and does 'make check syntax-check' 2
times per day.
https://people.freebsd.org/~novel/misc/libvirt_freebsd_ci.png
There are some occasional failures in tests and syntax-check is not
working quite well because of the 'file list too long' problem, still in
TODO list to fix that...
Roman Bogorodskiy