Re: [PATCH v2 3/3] qapi: deprecate drive-backup

24.05.2021 21:37, John Snow wrote: > On 5/24/21 10:06 AM, Vladimir Sementsov-Ogievskiy wrote: >> 15.05.2021 01:38, John Snow wrote: >>> On 5/6/21 5:57 AM, Kashyap Chamarthy wrote: >>>> TODO: We also need to deprecate drive-backup transaction action.. >>>> But union members in QAPI doesn't support 'deprecated' feature. I tried >>>> to dig a bit, but failed :/ Markus, could you please help with it? At >>>> least by advice? >>> >>> Oho, I see. >>> >>> OK, I'm not Markus, but I've been getting into lots of trouble in the QAPI generator lately, so let me see if I can help get you started... >>> >>> https://gitlab.com/jsnow/qemu/-/commits/hack-deprecate-union-branches/ >>> >>> Here's a quick hack that might expose that feature. I suppose we can discuss this with Markus and turn these into real patches if that's the direction we wanna head. >>> >> >> Hi! Markus is silent.. Maybe, you'll send patches ? ) >> >> > He just went on PTO for 2 weeks :') > It's going to have to wait, I'm afraid ... > Hi! Any plans or updates? John, may be you just send your patches?