Re: [libvirt] [PATCH 1/3] docs: website: remove search
On Mon, May 23, 2016 at 11:20:19AM -0400, Cole Robinson wrote:
On 05/20/2016 01:16 PM, Daniel P. Berrange wrote:
> On Fri, May 20, 2016 at 10:27:03AM -0400, Cole Robinson wrote:
>> It's currently broken:
>>
>> Could not connect to the database: Can't connect to local MySQL server
through socket '/var/lib/mysql/mysql.sock' (111)
>>
>> And honestly there's no way this can be as effective as a targeted
>> google search, so I think we should just drop it.
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=1337741
>
>> diff --git a/docs/page.xsl b/docs/page.xsl
>> index cd98f7d..9ae0129 100644
>> --- a/docs/page.xsl
>> +++ b/docs/page.xsl
>> @@ -143,14 +143,6 @@
>> <body>
>> <div id="header">
>> <div id="headerLogo"/>
>> - <div id="headerSearch">
>> - <form action="{$href_base}search.php"
enctype="application/x-www-form-urlencoded" method="get">
>> - <div>
>> - <input id="query" name="query"
type="text" size="12" value=""/>
>> - <input id="submit" name="submit"
type="submit" value="Search"/>
>> - </div>
>> - </form>
>> - </div>
>
>
> Instead of deleting this, I suggest that we simply change the action
> to point to google.com, and have a bit of javasccript that appends
> "site:libvirt.org" to the search string the user has entered in text
> field upon submission.
>
> This would also mean many of the other references to search you removed
> in this commit would remain in place too.
Okay, I'll look into it. How do you feel about the other two patches? dropping
the todolist stuff, and ChangeLog-old
Sure, that's fine with me.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|