Re: [libvirt] [PATCH v3] storage: Sanitize pool target paths

Phooey. Need a v4; this can fault. If you have "///" ending on a page boundary, then... > + bool slash_before = (offset != 0 && cur[-1] == '/'); > + > + /* Skip all extra / */ > + if (*cur == '/') { > + cur++; > + continue; > + } ...this advances cur to the '\0', and the next iteration of the nested do-while accesses past the trailing NUL when computing slash_follow.