Re: [libvirt] char: Logging serial pty output when disconnected
On Tue, Jan 31, 2017 at 7:34 AM, Paolo Bonzini <pbonzini(a)redhat.com> wrote:
On 31/01/2017 04:39, Daniel P. Berrange wrote:
> I don't think so - retrying in this way is pointless IMHO - it is just
> going to get the same result on every retry on 99% of occassions.
Just to provide the full context, the retry happens even if you get
EAGAIN, and in that case it does makes sense.
But if the pty is disconnected I agree it should discard the data.
Thanks for the feedback. Please refer to this proposed patch:
http://patchwork.ozlabs.org/patch/721974/ .
--Ed