Re: [libvirt] [PATCH] xenconfig: move contents to libxl driver and remove directory
On 8/26/19 5:49 AM, Ján Tomko wrote:
The 'From:' field shows your e-mail in uppercase.
Thanks for pointing that out! Seems the O365 server is doing it on my behalf
:-(. I've entered an internal ticket.
On Fri, Aug 23, 2019 at 07:50:12PM +0000, Jim Fehlig wrote:
> Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
> ---
> cfg.mk | 2 +-
> configure.ac | 2 --
> po/POTFILES | 6 ++---
> src/Makefile.am | 1 -
> src/libvirt_xenconfig.syms | 12 ----------
> src/libxl/Makefile.inc.am | 25 ++++++---------------
> src/{xenconfig => libxl}/xen_common.c | 0
> src/{xenconfig => libxl}/xen_common.h | 0
> src/{xenconfig => libxl}/xen_xl.c | 0
> src/{xenconfig => libxl}/xen_xl.h | 0
> src/{xenconfig => libxl}/xen_xm.c | 0
> src/{xenconfig => libxl}/xen_xm.h | 0
> src/{xenconfig => libxl}/xenxs_private.h | 0
> src/xenconfig/Makefile.inc.am | 28 ------------------------
> tests/xlconfigtest.c | 2 +-
> tests/xmconfigtest.c | 2 +-
> 16 files changed, 13 insertions(+), 67 deletions(-)
>
There's one occurrence left:
diff --git a/src/xenapi/Makefile.inc.am b/src/xenapi/Makefile.inc.am
index b6e4ed0bdb..aedef4e2a0 100644
--- a/src/xenapi/Makefile.inc.am
+++ b/src/xenapi/Makefile.inc.am
@@ -18,7 +18,6 @@ libvirt_driver_xenapi_la_CFLAGS = \
$(XENAPI_CFLAGS) \
$(CURL_CFLAGS) \
-I$(srcdir)/conf \
- -I$(srcdir)/xenconfig \
$(AM_CFLAGS) \
$(NULL)
libvirt_driver_xenapi_la_LDFLAGS = $(AM_LDFLAGS)
With that fixed:
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
I removed the other occurrence and pushed the patch.
Regards,
Jim