Re: [libvirt PATCH 2/2] ci: Call meson consistently
On Fri, Mar 26, 2021 at 05:11:04PM +0100, Andrea Bolognani wrote:
On Fri, 2021-03-26 at 17:00 +0100, Erik Skultety wrote:
> On Fri, Mar 26, 2021 at 11:35:02AM +0100, Andrea Bolognani wrote:
> > We should always pass --werror and display the contents of the
> > log file in case of failure.
> >
> > Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
> > ---
> Reviewed-by: Erik Skultety <eskultet(a)redhat.com>
Even though you didn't spell that out explicitly, I assume you're
okay with me pushing this series during the freeze?
I agree with Pavel here. Even though this is far from an intrusive change,
unless it's fixing a bug, we should keep our CI unchanged during the freeze
period in order to focus on stabilizing any failures before the release.
Erik