Re: [libvirt PATCH v2 05/15] conf: put hostdev PCI backend into a struct
On Mon, Nov 06, 2023 at 02:38:50 -0500, Laine Stump wrote:
The new struct is virDeviceHostdevPCIDriverInfo, and the
"backend"
enum in the hostdevDef will be replaced with a
virDeviceHostdevPCIDriverInfo named "driver'. Since the enum value in
this new struct is called "type", it means that all references to
"backend" will become "driver.type".
This will allow easily adding other items for new attributes in the
<driver> element / C struct, which will be useful once we are using
this new struct in multiple places.
Signed-off-by: Laine Stump <laine(a)redhat.com>
---
[...]
I will not repeat the comment about unneeded linebreaks.
@@ -29973,14 +29973,10 @@
virDomainNetDefActualToNetworkPort(virDomainDef *dom,
break;
case VIR_DEVICE_HOSTDEV_PCI_DRIVER_TYPE_XEN:
- virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
- _("Unexpected PCI backend 'xen'"));
- break;
-
Falling through to virReportEnumRangeError from such cases isn't
something we normally do as virReportEnumRangeError is usually meant for
cases when the value is unknown.
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>