Re: [libvirt] [PATCH] Refactor ESX storage driver and add iSCSI support
2012/9/9 Ata Bohra <ata.husain(a)hotmail.com>:
> Date: Sun, 9 Sep 2012 21:12:43 +0200
> Subject: Re: [libvirt] [PATCH] Refactor ESX storage driver and add iSCSI
> support
> From: matthias.bolte(a)googlemail.com
> To: ata.husain(a)hotmail.com
> CC: libvir-list(a)redhat.com
>
>
> This patch is quite huge. Maybe you could split it up into two
> patches. The first one for adding the backend structure to the storage
> driver and moving the current driver code to its own backend. The
> second patch for adding the new iSCSI backend.
At first, I was thinking of doing the same but somehow felt that presenting
everything in one patch may make more sense. But your feedback suggests that
breaking the patch would help better management as well as review. Will do
as suggested in the next patch version.
Thanks!Ata
With over 4000 lines of change your patch is quite huge, that makes it
harder to understand all the changes you're making. There are 3 major
parts in this patch.
1. Adding the backend concept.
2. Move the current driver logic to a backend.
3. Adding a new backend.
Doing 1 and 2 in one patch and 3 in a second patch will simplify the
review process, because one is not forced to focus on all 3 aspects as
once :)
--
Matthias Bolte
http://photron.blogspot.com