Re: [PATCH 1/3] qemu: Revert to using non-JSON commandline for -device

On Mon, 3 Jan 2022, Ani Sinha wrote: > > > On Mon, 3 Jan 2022, Peter Krempa wrote: > > > When -device is configured via JSON a bug is triggered in qemu were the > > DEVICE_DELETED event for the removal of the device frontend is no longer > > delivered to libvirt. Without the DEVICE_DELETED event we don't remove > > the corresponding entries in the VM XML. > > > > Until qemu will be fixed we must stop using the JSON syntax for -device. > > > > This patch removes the detection of the capability. The capability is > > used only during startup of a fresh VM so we don't need to consider any > > compaitibility steps for existing VMs. > > > > Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; > > --- > > src/qemu/qemu_capabilities.c | 1 - > > .../caps_6.2.0.aarch64.xml | 1 - > > .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 1 - > > .../caps_6.2.0.x86_64.xml | 1 - > > I understand the caps changes but not sure why the args files below needed > to be changed. Seems to me rebase issue? Otherwise LGTM. Never mind. Not usng the json syntax in qemu commandline.

> > ...fault-cpu-kvm-virt-4.2.aarch64-latest.args | 6 +-- > > ...fault-cpu-tcg-virt-4.2.aarch64-latest.args | 6 +--