Re: [PATCH 1/2] docs: Clarify hypervisor support for nwfilter profiles

On 9/11/24 15:54, Demi Marie Obenour wrote: > On Wed, Sep 11, 2024 at 03:02:41PM -0600, Jim Fehlig wrote: >> Enhance the 'since' annotation of <filterref> documentation to note >> it's only supported by the QEMU, LXC, and ch hypervisor drivers. >> >> Signed-off-by: Jim Fehlig <jfehlig(a)suse.com&gt; >> --- >>   docs/formatdomain.rst | 8 ++++---- >>   1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst >> index 47d3e2125e..8e8a9660fc 100644 >> --- a/docs/formatdomain.rst >> +++ b/docs/formatdomain.rst >> @@ -6205,10 +6205,10 @@ hypervisor tries to reconnect. >>   Traffic filtering with NWFilter >>   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> -:since:`Since 0.8.0` an ``nwfilter`` profile can be assigned to a >> domain >> -interface, which allows configuring traffic filter rules for the >> virtual >> -machine. See the `nwfilter <formatnwfilter.html>`__ documentation >> for more >> -complete details. >> +:since:`Since 0.8.0 (QEMU), 0.9.3 (LXC), 10.1.0 (Cloud Hypervisor)` >> an ``nwfilter`` >> +profile can be assigned to a domain interface, which allows >> configuring traffic >> +filter rules for the virtual machine. See the `nwfilter >> <formatnwfilter.html>`__ >> +documentation for more complete details. >>   :: >> -- >> 2.35.3 > > Should this have a > > Suggested-by: Demi Marie Obenour <demi(a)invisiblethingslab.com&gt; > > tag? I've added that. > In any case: > > Acked-by: Demi Marie Obenour <demi(a)invisiblethingslab.com&gt; I don't recall use of 'Acked-by' in libvirt for a long time. 'git log' seems to confirm that. Neither the contributor or committer guidelines say much about it https://libvirt.org/hacking.html https://libvirt.org/committer-guidelines.html I'm happy to add it, or 'Reviewed-by' if you're fine with that, but would like to hear opinions from other maintainers on this topic.