Re: [libvirt] [PATCH 1/8] util: new function virPCIDeviceGetVFIOGroupDev

On 04/25/2013 11:57 AM, Laine Stump wrote: > Given a virPCIDevice, this function returns the path for the device > that controls the vfio group the device belongs to, > e.g. "/dev/vfio/15". > --- > + if (virAsprintf(&groupDev, "/dev/vfio/%s", basename(groupPath)) < 0) { We shouldn't be using basename() from <libgen.h> - it has horrible portability problems, and is not thread-safe. Instead, use last_component() from gnulib's "dirname.h". [I really ought to add a syntax-check to cfg.mk and clean up the existing offenders]. ACK with that fixed.