Re: [libvirt] [PATCH jenkins-ci 2/2] Enable mingw build for virt-viewer project
On Fri, Apr 13, 2018 at 03:40:49PM +0200, Andrea Bolognani wrote:
On Fri, 2018-04-13 at 14:25 +0100, Daniel P. Berrangé wrote:
> On Fri, Apr 13, 2018 at 03:05:10PM +0200, Andrea Bolognani wrote:
> > No, wait, actually its native variant is, but the same is true for
> > the Adwaita icon theme. Weird. I don't see how we would need one of
> > them to be native and the other to be MinGW, they should match.
>
> I think that highcolor line is obsolete cruft leftover when when
> we added dep on mingw32 adwaita theme.
I just tried and it looks like neither mingw*-adwaita-* nor
mingw*-hicolor-* seems to be required to build virt-viewer,
actually. I think we can safely avoid listing them altogether.
That'll be because the icon theme is only needed when we build the
MSI installer, and that's not part of the default "make" target
we're running here. That is something I ought to fix :-)
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|