Re: [libvirt PATCH 06/12] conf: add failover attribute to <driver> subelement of <interface>

On 1/21/20 10:26 AM, Daniel P. Berrangé wrote: > On Sun, Jan 19, 2020 at 10:24:13PM -0500, Laine Stump wrote: > > This attribute is only used for virtio-net devices, so it is stored in > > the virtio part of the anonymous union in virDomainNetDef::driver. An > I'm not convinced that storing it only for virtio-net is the > right approach. This feels like a generic concept, that just > happens to only be implemented by virtio-net in QEMU today. > IOW, it is valid to store it in the virDOmainNetDef in a > place that's generally applicable. Any restriction to virtio-net > belongs in the QEMU driver, rather than the XML parser. Agreed, although in light of your comment on 8/12 (suggesting we just create an entire new subelement), I guess the point is moot :-)