Re: [Libvir] PATCH 4/4: Xen test suite support
"Daniel P. Berrange" <berrange(a)redhat.com> wrote:
This patch updates the Xen test suite to cover the new serial and
paralle
device syntax extensions
Looks good.
sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml | 44 ++
sexpr2xmldata/sexpr2xml-fv-serial-file.xml | 48 ++
sexpr2xmldata/sexpr2xml-fv-serial-null.xml | 46 ++
sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml | 48 ++
sexpr2xmldata/sexpr2xml-fv-serial-pty.xml | 46 ++
sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml | 46 ++
sexpr2xmldata/sexpr2xml-fv-serial-tcp-telnet.xml | 48 ++
sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml | 48 ++
sexpr2xmldata/sexpr2xml-fv-serial-udp.xml | 50 ++
sexpr2xmldata/sexpr2xml-fv-serial-unix.xml | 48 ++
xmconfigdata/test-fullvirt-parallel-tcp.xml | 45 ++
xmconfigdata/test-fullvirt-serial-file.xml | 49 ++
xmconfigdata/test-fullvirt-serial-null.xml | 47 ++
xmconfigdata/test-fullvirt-serial-pipe.xml | 49 ++
xmconfigdata/test-fullvirt-serial-pty.xml | 47 ++
xmconfigdata/test-fullvirt-serial-stdio.xml | 47 ++
xmconfigdata/test-fullvirt-serial-tcp-telnet.xml | 49 ++
xmconfigdata/test-fullvirt-serial-tcp.xml | 49 ++
xmconfigdata/test-fullvirt-serial-udp.xml | 51 ++
xmconfigdata/test-fullvirt-serial-unix.xml | 49 ++
xml2sexprdata/xml2sexpr-fv-parallel-tcp.xml | 40 ++
xml2sexprdata/xml2sexpr-fv-serial-file.xml | 40 ++
xml2sexprdata/xml2sexpr-fv-serial-null.xml | 39 ++
xml2sexprdata/xml2sexpr-fv-serial-pipe.xml | 40 ++
xml2sexprdata/xml2sexpr-fv-serial-pty.xml | 39 ++
xml2sexprdata/xml2sexpr-fv-serial-stdio.xml | 39 ++
xml2sexprdata/xml2sexpr-fv-serial-tcp-telnet.xml | 40 ++
xml2sexprdata/xml2sexpr-fv-serial-tcp.xml | 40 ++
xml2sexprdata/xml2sexpr-fv-serial-udp.xml | 41 ++
xml2sexprdata/xml2sexpr-fv-serial-unix.xml | 40 ++
I noticed that there's a huge amount of duplication in these new .xml
files. Each typically differs in just a single attribute or two from
one or more others.
Eventually, it'd be good for maintainability to factor out some sort of
template(s) and store in version control only the pieces that say how
to change a template into the desired expected output file.