Re: [PATCH] scripts: Fix the flake8 syntax-check failures
On 6/5/23 09:40, Han Han wrote:
Fix the syntax-check failures with the help of isort[1]:
289/316 libvirt:syntax-check / flake8 FAIL 5.24s exit status 2
[1]: https://pycqa.github.io/isort/
Signed-off-by: Han Han <hhan(a)redhat.com>
---
ci/util.py | 3 +--
run.in | 2 +-
scripts/apibuild.py | 6 +++---
scripts/check-html-references.py | 4 ++--
scripts/check-pot.py | 2 +-
scripts/esx_vi_generator.py | 3 +--
scripts/hvsupport.py | 2 +-
scripts/hyperv_wmi_generator.py | 2 +-
scripts/meson-timestamp.py | 1 -
src/cpu_map/sync_qemu_models_i386.py | 3 ++-
tests/cputestdata/cpu-data.py | 1 -
tests/virsh-auth | 2 +-
tools/virt-qemu-qmp-proxy | 9 +++++----
tools/virt-qemu-sev-validate | 9 +++++----
14 files changed, 24 insertions(+), 25 deletions(-)
Might be worth mentioning the error can be seen only after
'python3-flake8-import-order.noarch' package is installed. And there's
another change needed:
diff --git a/scripts/meson-dist.py b/scripts/meson-dist.py
index 1c2364f6b6..bb751b97d3 100755
--- a/scripts/meson-dist.py
+++ b/scripts/meson-dist.py
@@ -1,8 +1,8 @@
#!/usr/bin/env python3
import os
-import sys
import shutil
+import sys
meson_build_root = sys.argv[1]
file_name = sys.argv[2]
Fixed commit message, squashed in this hunk and pushed.
Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com>
Michal