On 04/09/2013 07:13 AM, Eric Blake wrote:
On 04/09/2013 03:08 AM, Daniel P. Berrange wrote:
>
>> I'm trying to understand what the behavior was before this patch went in.
>
> Well this was just fixing a deadlock introduced in a previous patch.
> You need to look further back than just this patch. Originally the
> global QEMU driver lock would be held preventing any kind of concurrent
> execution.
In fact, my testing said that this patch, in isolation, merely set up a
latent bug, but did not cause a crash, precisely because back at that
time in history, we were still being protected by the big qemu driver
lock. I'm still bisecting, though, to determine _which_ patch finally
allowed this latent issue to finally crash libvirtd.
For cross-thread closure, my bisect results are here:
https://www.redhat.com/archives/libvir-list/2013-April/msg00721.html
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org