Re: [libvirt] [PATCH v2] Fix libvirtd crash possibility

On 09/12/2012 05:00 PM, Eric Blake wrote: > On 09/12/2012 04:44 PM, Martin Kletzander wrote: >> When generating RPC protocol messages, it's strictly needed to have >> continuousline of numbers or RPC messages. However in case anyone > > s/continuousline/a continuous line/ > >> tries backporting some functionality and will skip a number, there is >> a possibility to make the daemon segfault with newer virsh (version of >> the library, rpc call, etc.) even unintentionally. >> >> The problem is that the skipped numbers will get func filled with >> NULLs, but there is no check whether these are set before the daemon >> tries to run them. This patch very simply enhances one check and fixes >> that. >> --- >> src/rpc/virnetserverprogram.c | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) > > ACK. If you haven't pushed yet, you may want to amend the commit message to mention that this appears to be a regression introduced in commit df0b57a9, in our RPC refactoring for 0.9.3.