[libvirt] [PATCH v7 00/11] qemu: Validate PCI controller options

Applies cleanly on top of b932ed69f6664f42e211bdde84c8ab04e1f19033. Patches 2/11 and 4/11 are the only ones missing R-bs, everything else hasn't been significantly altered since [v5]. Changes from [v6]: * don't special-case the default PHB when checking capabilities. Changes from [v5]: * patch 1 has been pushed; * add virReportController*() functions to cut down on redundant error reporting, as suggested by laine; * report index and modelName along with model in error messages. Changes from [v4]: * patch 1/12 is new; * use virReportEnumRangeError(), as suggested by laine. Changes from [v3]: * don't introduce new test cases that won't be able to provide full test coverage anyway, as suggested by laine. Changes from [v2]: * replace the old implementation bit by bit using a clever trick suggested by pkrempa; * don't move QEMU capability validation; * add a default: label to all switch statements as recommended by danpb. Changes from [v1]: * error out instead of silently accept invalid options; * shave quite a lot of yaks. [v6] https://www.redhat.com/archives/libvir-list/2018-March/msg00203.html [v5] https://www.redhat.com/archives/libvir-list/2018-March/msg00096.html [v4] https://www.redhat.com/archives/libvir-list/2018-February/msg01232.html [v3] https://www.redhat.com/archives/libvir-list/2018-February/msg00996.html [v2] https://www.redhat.com/archives/libvir-list/2018-February/msg00813.html [v1] https://www.redhat.com/archives/libvir-list/2018-February/msg00244.html Andrea Bolognani (11): qemu: Create new qemuDomainDeviceDefValidateControllerPCI() qemu: Validate PCI controller options (modelName) qemu: Validate PCI controller options (index) qemu: Validate PCI controller options (targetIndex) qemu: Validate PCI controller options (pcihole64) qemu: Validate PCI controller options (busNr) qemu: Validate PCI controller options (numaNode) qemu: Validate PCI controller options (chassisNr) qemu: Validate PCI controller options (chassis and port) qemu: Validate PCI controllers (QEMU capabilities) qemu: Remove old qemuDomainDeviceDefValidateControllerPCI() src/qemu/qemu_domain.c | 531 +++++++++++++++++-------- tests/qemuxml2argvdata/pcie-expander-bus.xml | 3 - tests/qemuxml2argvtest.c | 38 +- tests/qemuxml2xmloutdata/pcie-expander-bus.xml | 4 +- tests/qemuxml2xmltest.c | 31 +- 5 files changed, 432 insertions(+), 175 deletions(-) -- 2.14.3