Re: [PATCH] storage_util: Fix the false condition in virStorageBackendDeviceIsEmpty
On a Wednesday in 2023, Han Han wrote:
In virStorageBackendDeviceIsEmpty, the return value for
virStorageBackendPARTEDValidLabel is -1 or 0. That makes the later
condition 'ret == -2' make always false. Remove the always false
condition.
Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.
Fixes: https://gitlab.com/libvirt/libvirt/-/issues/576
As Michal pointed out in the linked issue, the functions return -2 if
the functionality was not compiled in.
Jano
Signed-off-by: Han Han <hhan(a)redhat.com>
---
src/storage/storage_util.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
Attachments:
- signature.asc (application/pgp-signature — 228 bytes)