Re: [libvirt] [PATCH 3/3] conf: Fix perf event parser
On Thu, Jun 16, 2016 at 14:11:39 -0400, John Ferlan wrote:
On 06/15/2016 11:15 AM, Peter Krempa wrote:
> The parser was totaly broken. Fix it by rewriting it. Add tests so that
> it doesn't happen.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1346723
> ---
> src/conf/domain_conf.c | 47 ++++++++++++-----------------
> tests/genericxml2xmlindata/generic-perf.xml | 22 ++++++++++++++
> tests/genericxml2xmltest.c | 2 ++
> 3 files changed, 43 insertions(+), 28 deletions(-)
> create mode 100644 tests/genericxml2xmlindata/generic-perf.xml
ACK,
John
FWIW:
There is a tests/domainschemadata/domain-perf-simple.xml from commit id
'afe833e9b'....
I'll drop it in a follow up. That file doesn't make sense since it's not
excercising the XML code and we can do it by the test I've added.