Re: [libvirt] [PATCHv3 4/5] snapshot: Add flag to allow hypervisor restart when reverting snapshots
On 11/13/2012 08:28 AM, Peter Krempa wrote:
I should have added code to libvirt.c that will set the _RESPAWN flag
when force is specified to save hassle. I will do it in the next version
if this idea doesn't get NACKed to oblivion.
I'm still thinking about the original patch, but _don't_ add code to
libvirt.c that turns on one flag when another is present. Remember,
virsh linked to libvirt.so 1.0.1 can call into libvirtd linked to
libvirt.so 1.0.0, and if libvirt.c auto-sets the _RESPAWN flag in 1.0.1,
then the RPC call will fail because 1.0.0 will reject it.
Any automatic handling of assuming _RESPAWN if _FORCE is present must be
done in the individual drivers, such as qemu_driver.c.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 617 bytes)