Re: [libvirt] RFC: virt-console
On Tue, Jul 01, 2008 at 07:50:02PM +0100, John Levon wrote:
On Tue, Jul 01, 2008 at 07:35:56PM +0100, Daniel P. Berrange wrote:
> > --- /dev/null 2008-06-30 17:03:12.000000000 -0700
> > +++ libvirt-new/src/virt-console.c 2008-06-30 16:58:36.079071463 -0700
>
> I'd prefer to keep the source in the 'console.c' file instead of
renaming
> it, just to make historical diff tracking a little easier.
Really? Surely even subversion can do cross-rename tracking OK?
We're using CVS for libvirt & yes it sucks :-)
> I like the support for re-connecting after reboot. At the same
time I
> wonder if we need to make the an optional command line flag. Some apps
> using virsh console, may rely on the fact that it exits when a VM
> shuts down.
I hate --behave-like-you-should flags and will do everything I can to
avoid them. Let's not inconvenience everybody for the sake of some
possible breakage. The perils of people coding to human interfaces. (I
wanted to make --verbose the default, like telnet, but that seemed much
more likely to break someone's scripts).
I'm mostly concerned about 'virsh console' - we only need to keep
compatability for that. The standalone virt-console can have the
auto-track restarts syntax and we can recommend use for virt-console
as the primary tool, just having virsh console for compat.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|