Re: [libvirt] [virt-tools-list] virt-manager/libvirt backwards compatibility problem?

Pasting from that URL gave awkward results below; can you address my comments below, then post a v2 as a proper patch against libvirt.git?

I don't like this part. It is not safe to pass %s as the pathname through an additional round of shell parsing, since if the pathname has anything that might be construed as shell metacharacters, the parse will be destroyed. To some extent, that is already a pre-existing bug (slightly mitigated by the fact that 'path' is under libvirt's control, and should not be containing arbitrary characters unless you passed odd directory choices to ./configure).