Re: [libvirt] [PATCH 2/3] tests: qemustatusxml2xml: Add a seclabel for a disk with privateData
On Tue, Jun 25, 2019 at 10:46:28 +0200, Ján Tomko wrote:
On Mon, Jun 24, 2019 at 06:27:12PM +0200, Peter Krempa wrote:
> Adding a seclabel breaks the output by improperly handling the XPath
> context and thus not being able to parse the <privateData>.
>
However nice it is to see the effects of the fix during review, I think
we should not be adding broken test data and this should be squashed
with the next commit.
In that case it's pretty pointless to have the first commit as well.
I could also argue that the input data is valid in this case, so it's
not broken test data. Only the output is broken here.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)