Re: [libvirt] [PATCH] pass correct uri to source host when we do p2p migration
At 01/10/2011 07:02 PM, Daniel P. Berrange Write:
On Mon, Jan 10, 2011 at 11:20:31AM +0800, Wen Congyang wrote:
> When we migrate a guest from remote host to localhost by p2p, the libvirtd
> on remote host will be deadlock. This patch fixes a bug and we can avoid
> the deadlock with this patch.
>
> The steps to reproduce this bug:
> # virsh -c qemu+ssh://<remotehost IP>/system migrate --p2p <domain name>
qemu+ssh:///system
>
> We connect dest host(qemu+ssh:///system) on source host, and the uri we pass
> to source host is qemu+ssh:///system. And then we connect a wrong dest host.
IMHO, we should be reporting an error in this scenario, because the
user is specifying a combination of parameters that don't make
sense.
I don't think so. If we don't use --p2p, the migration can finish.
If we reporting an error here, the behavior of this command will
be strange(success without --p2p, but fail with --p2p).
Daniel