Re: [PATCH 0/2] libvirt-guests: small improvments
On Mon, Jul 31, 2023 at 05:06:44PM -0600, Jim Fehlig wrote:
The first patch is trivial. I suppose the second is debatable. If I
build
libvirt with -Dremote_default_mode=legacy but deploy modular daemons,
/run/libvirt/libvirt-sock is provided by virtproxyd, which may or may not
be running when libvirt-guests starts/stops. I added an 'After=virtproxyd.socket'
ordering dependency to libvirt-guests, but it hasn't fixed an issue I'm
seeing when using libvirt-guests+virtproxyd
libvirt-guests.sh[2607]: Can't connect to default. Skipping
In this case the connection should use the legacy mode according to the
code.
I think you are running into the same thing as we were in
https://bugzilla.redhat.com/show_bug.cgi?id=1964855
and you want to have virtproxyd.service instead of virtproxyd.socket
there. It's complicated, but look at my commit 59d30adacd1d and comment
#7 in the above mentioned bugzilla.
In any case I think in such a scenario you want the libvirt-guests to
connect to the particular daemon. That's the reason I did not modify
the virtproxyd in the commit and the reason the socket is not in the
service file.
I'm still investigating that issue but think the dependency issue
is worth
discussing independently.
Jim Fehlig (2):
libvirt-guests: Remove unused variable 'libvirtd'
libvirt-guests: Add systemd odering dependency to virtproxyd
tools/libvirt-guests.service.in | 1 +
tools/libvirt-guests.sh.in | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
--
2.41.0
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)