Re: [PATCH RESEND 2/5] qemuProcessStartManagedPRDaemon: Don't pass -f pidfile to the daemon
Hi
On Mon, Mar 23, 2020 at 6:48 PM Michal Prívozník <mprivozn(a)redhat.com> wrote:
On 23. 3. 2020 17:36, Marc-André Lureau wrote:
> Hi
>
> On Mon, Mar 23, 2020 at 5:16 PM Michal Privoznik <mprivozn(a)redhat.com> wrote:
>>
>> Now, that our virCommandSetPidFile() is more intelligent we don't
>> need to rely on the daemon to create and lock the pidfile and use
>> virCommandSetPidFile() at the same time.
>>
>> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
>
> Nice, but doesn't this also fix a temporary regression introduced by
> previous commit, now that pidfile is locked?
Yeah, I haven't found a way to do this regression free.
Either squash them,
Or add a fat warning on the previous commit, and mention that you fix
it here too.
With that,
Reviewed-by: Marc-André Lureau <marcandre.lureau(a)redhat.com>
--
Marc-André Lureau