Re: [PATCH v6 2/3] domain_addr: Fix virtio console port autoassign on virtio-serial bus
On Tue, Jul 22, 2025 at 13:50:19 -0400, Aaron M. Brown wrote:
One definition per line.
Okay I will remember that going forward!
This is suspicious because this function until now just returned the
next eligible port, but now it's also reserving it which doesn't seem to
fit well here.
Can you please explain this?
Yes, I agree with you Peter, it is a bit unfitting, we can't process a port
assigned to port 0 in virDomainVirtioSerialAddrReserve as it fails the
virDomainVirtioSerialAddrIsComplete check, because that check makes sure that
`info->addr.vioserial.port != 0` so such a port would show as imcomplete.
And if we skip over reserving this port, that means the bitmap would show a clear bit at
the first position for every subsequent device on the controller