Re: [libvirt] [PATCH v3 1/3] qemuxml2argvtest: Set more fake drivers
On 07/27/2018 05:29 PM, Daniel P. Berrangé wrote:
On Fri, Jul 27, 2018 at 05:24:45PM +0200, Michal Privoznik wrote:
> So far we are setting only fake secret and storage drivers.
> Therefore if the code wants to call a public NWFilter API (like
> qemuBuildInterfaceCommandLine() and qemuBuildNetCommandLine() are
> doing) the virGetConnectNWFilter() function will try to actually
> spawn session daemon because there's no connection object set to
> handle NWFilter driver.
>
> Even though I haven't experienced the same problem with the rest
> of the drivers (interface, network and node dev), the reasoning
> above can be applied to them as well.
>
> At the same time, now that connection object is registered for
> the drivers, the public APIs will throw
> virReportUnsupportedError(). And since we don't provide any error
> func the error is printed to stderr. Fix this by setting dummy
> error func.
Is this last paragraph stale ? you're not seeing a dummy error
func in this patch ...
Oh yes, I am:
libvirt.git/tests $ VIR_TEST_DEBUG=1 ./qemuxml2argvtest 2>&1 | grep "this
function is not supported"
441) QEMU XML-2-ARGV net-vhostuser-multiq ... libvirt:
Network Filter Driver error : this function is not supported by the connection driver:
virNWFilterBindingLookupByPortDev
libvirt: Network Filter Driver error : this function is not supported by the connection
driver: virNWFilterBindingLookupByPortDev
libvirt: Network Filter Driver error : this function is not supported by the connection
driver: virNWFilterBindingLookupByPortDev
2018-07-27 16:02:50.689+0000: 11166: error : virNWFilterBindingLookupByPortDev:599 : this
function is not supported by the connection driver: virNWFilterBindingLookupByPortDev
2018-07-27 16:02:50.689+0000: 11166: error : virNWFilterBindingLookupByPortDev:599 : this
function is not supported by the connection driver: virNWFilterBindingLookupByPortDev
2018-07-27 16:02:50.689+0000: 11166: error : virNWFilterBindingLookupByPortDev:599 : this
function is not supported by the connection driver: virNWFilterBindingLookupByPortDev
(Or even without DEBUG)
But as I told Peter, at this point stopping touching live user data is
more important to me than silencing some error message.
Michal