On 09/14/12 11:47, Peter Krempa wrote:
On 09/14/12 10:38, Osier Yang wrote:
> This is to list the secret objects. No flags are supported
This statement isn't accurate as you added filtering flags.
>
> include/libvirt/libvirt.h.in: Declare enum virConnectListAllSecretFlags
> and virConnectListAllSecrets.
> python/generator.py: Skip auto-generating
> src/driver.h: (virDrvConnectListAllSecrets)
> src/libvirt.c: Implement the public API
> src/libvirt_public.syms: Export the symbol to public
> ---
> include/libvirt/libvirt.h.in | 21 +++++++++++++
> python/generator.py | 1 +
> src/driver.h | 5 +++
> src/libvirt.c | 66
> ++++++++++++++++++++++++++++++++++++++++++
> src/libvirt_public.syms | 1 +
> 5 files changed, 94 insertions(+), 0 deletions(-)
>
> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
> index 3d41026..c38ab23 100644
> --- a/include/libvirt/libvirt.h.in
> +++ b/include/libvirt/libvirt.h.in
> @@ -3266,6 +3266,27 @@ int virConnectNumOfSecrets
> (virConnectPtr conn);
> int virConnectListSecrets (virConnectPtr conn,
> char **uuids,
> int maxuuids);
> +
> +/*
> + * virConnectListAllSecrets:
> + *
> + * Flags used to filter the returned secrets. Flags in each group
> + * are exclusive attributes of a secret.
> + */
> +typedef enum {
> + /* kept in memory, never stored persistently */
> + VIR_CONNECT_LIST_SECRETS_EPHEMERAL = 1 << 0,
> + VIR_CONNECT_LIST_SECRETS_NO_EPHEMERAL = 1 << 1,
> +
> + /* not revealed to any caller of libvirt, nor
> + * to any other node */
> + VIR_CONNECT_LIST_SECRETS_PRIVATE = 1 << 2,
> + VIR_CONNECT_LIST_SECRETS_NO_PRIVATE = 1 << 3,
You also need to move the comments for this after the first value,
otherwise the docs generator is confused and moves the comments
"off-by-one".
Peter