Re: [libvirt] [PATCH] qemu: blockjob: Fix saving of inactive XML after completed legacy blockjob
On Fri, May 17, 2019 at 10:22:16AM +0200, Peter Krempa wrote:
Commit 0ba9afc6b28 introduced a logic bug where we will never save the
On second glance, that commit still looks okay to me logic-wise.
Commit c257352797 seems to be the culprit here.
inactive XML after a blockjob as the variable which was determining
whether to do so is cleared right before. Thus even if we correctly
modify the inactive state it will be rolled back when libvirtd is
restarted.
Reported-by: Thomas Stein <hello(a)himbee.re>
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
src/qemu/qemu_blockjob.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
Attachments:
- signature.asc (application/pgp-signature — 488 bytes)