Re: [libvirt] [PATCH v4 2/5] blockjob: turn on qemu capability bit for active commit

On 06/24/14 01:30, Eric Blake wrote: > Use the probing functionality added in the last patch to turn on > a capability bit when active commit is present, and gate active > commit on that capability. > > For my own reference: the difference between BLOCKJOB_SYNC and > BLOCKJOB_ASYNC is whether qemu generated an event at the > conclusion of blockpull; basically, RHEL 6.2 was the only release > of qemu that has the sync semantics and lacks the event. RHEL > 6.3 added blockcopy, but also picked up on the upstream style > of qemu generating events. As no one is likely to backport > active commit to RHEL 6.2, it's safe for blockcommit to always > require async blockjob support. > > Modifying qemucapabilitiestest is painful; the .replies files would > be so much easier if they had comments correlating which command > generated the given reply. Maybe I'll fix that up later... >

ACK,