Re: [libvirt] [PATCH 2/2 v3] remote: Refuse connecting to remote socket
On 08/26/2011 03:56 AM, Michal Privoznik wrote:
If users wants to connect to remote unix socket, e.g.
'qemu+unix://<remote>/system' currently the<remote> part is
ignored,
ending up connecting to localhost. Connecting to remote socket is not
supported and user should have used TLS/TCP/SSH instead.
---
+ if (conn->uri->server) {
+ remoteError(VIR_ERR_INVALID_ARG, "%s",
+ _("using unix socket and remote "
+ "server is not supported."));
You didn't take my suggestion at mentioning conn->uri->server in the
error message. But that's a minor point, so I'm okay giving ACK,
whether or not you make that tweak before pushing.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org