Re: [libvirt] [PATCH 4/7] Move virStoragePerms to libvirt_util
On Fri, Sep 25, 2009 at 02:27:30PM +0100, Mark McLoughlin wrote:
Rename to virStorageFilePerms and move to util/storage_file.[ch]
* src/conf/storage_conf.h: move perms struct from here ...
* src/util/storage_file.h: ... to here
* src/conf/storage_conf.c: update
---
src/conf/storage_conf.c | 2 +-
src/conf/storage_conf.h | 18 +++---------------
src/util/storage_file.h | 9 +++++++++
3 files changed, 13 insertions(+), 16 deletions(-)
NACK, i think this is redundant if we re-factor the file probing
code just a little.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|