Re: [libvirt] PATCH: 11/14: Change XM driver in-memory objects
On Thu, Jul 24, 2008 at 10:44:18AM -0400, Daniel Veillard wrote:
On Tue, Jul 08, 2008 at 05:40:17PM +0100, Daniel P. Berrange wrote:
> This is a refactoring of the XM driver. Previously we would store
> the virConfPtr objects as our master 'in memory' representation
> of inactive domains. This switch it over to using virDomainDefPtr
> objects instead. The code for reading/writing the config files is
> unchanged at this time.
[...]
> @@ -1291,9 +1217,10 @@ int xenXMDomainPinVcpu(virDomainPtr doma
> xenXMConfCachePtr entry;
> virBuffer mapbuf = VIR_BUFFER_INITIALIZER;
> char *mapstr = NULL;
> - char *ranges = NULL;
> int i, j, n, comma = 0;
> int ret = -1;
> + char *cpuset = NULL;
> + int maxcpu = 4096;
hum, we use MAX_VIRT_CPUS at places
I've checked up on this now - MAX_VIRT_CPUS refers to the Xen hypervisor
and kernel limits on virtual CPUs - this is currently 32 or 64 depending
on the architecture. The libvirt code here is refering to physical CPUs,
whose limit is independant of virtual CPU limit, so we shouldnt' use
the MAX_VIRT_CPUS constant here. I'll just #define a constant at the
top of this file for now.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|