Re: [libvirt] [PATCH 00/11] storage: modularize the storage driver backends

On Wed, Feb 08, 2017 at 05:27:00PM +0100, Peter Krempa wrote: BTW, it has been 9 years since we enabled dlopen for the main drivers. Initially it was tedious to use when running from non-installed git build dir, but we fixed that in 2014 with virFileFindResource, so that it "just works". The only bug we ever hit was when we initially tried to modularize even the non-daemon drivers, and it broke usage from language bindings. Every platform we care about, including Windows, has dlopen() or equivalent functionality. So perhaps it is time to *drop* support for building without modules. It will simplify our makefiles quite a bit to be able to assume everything is always dlopen'd modules, and will slightly simplify the code, and most importantly ensure a single codepath, so we know the behaviour is always the same. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|