Re: [libvirt] [PATCH 15/24] maint: improve VIR_ERR_INVALID_INTERFACE usage

On 12/28/2013 11:11 AM, Eric Blake wrote: > When checking for a valid interface, we weren't consistent on > whether ew reported as VIR_FROM_NONE or VIR_FROM_INTERFACE.

> Similar to previous patches, use a common macro to make it nicer. > For now, we don't need virCheckInterfaceGoto(). > > * src/datatypes.h (virCheckInterfaceReturn): New macro. > (VIR_IS_INTERFACE, VIR_IS_CONNECTED_INTERFACE): Drop unused > macros. > * src/libvirt.c: Use macro throughout. > (virLibInterfaceError): Drop unused macro. > > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; > --- > src/datatypes.h | 17 +++++++++---- > src/libvirt.c | 74 +++++++++++++++------------------------------------------ > 2 files changed, 32 insertions(+), 59 deletions(-) > Same concern as Networks - the virInterfaceGetName() and virInterfaceGetMACString() will require a connection...

ACK