Re: [libvirt] [PATCH] remove the dead code this patch is to remove the dead code Signed-off-by: JieWang <wangjie88@huawei.com>

On Mon, Aug 22, 2016 at 01:30:08PM +0100, Richard W.M. Jones wrote: > On Mon, Aug 22, 2016 at 08:17:37PM +0800, JieWang wrote: >> Signed-off-by: JieWang <wangjie88(a)huawei.com&gt; >> --- >> src/qemu/qemu_migration.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c >> index 6a683f7..759e15a 100644 >> --- a/src/qemu/qemu_migration.c >> +++ b/src/qemu/qemu_migration.c >> @@ -1602,7 +1602,6 @@ qemuMigrationPrecreateDisk(virConnectPtr conn, >> _("cannot precreate storage for disk type '%s'"), >> virStorageTypeToString(disk->src->type)); >> goto cleanup; >> - break; >> } >> >> if ((vol = virStorageVolLookupByName(pool, volName))) { > > ACK. > > As this seems completely trivial, I pushed it without waiting for a > second ACK, although I did compile-test it. > You could've fixed the commit message in order for it not to be all in one line... Well, maybe next time. > Rich. > > -- > Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones > Read my programming and virtualization blog: http://rwmj.wordpress.com > virt-p2v converts physical machines to virtual machines. Boot with a > live CD or over the network (PXE) and turn machines into KVM guests. > http://libguestfs.org/virt-v2v > > -- > libvir-list mailing list > libvir-list(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list