Re: [PATCH 5/5] qemu_validate.c: revert NUMA CPU range user warning
On Mon, Jun 01, 2020 at 14:50:41 -0300, Daniel Henrique Barboza wrote:
Now that we have the auto-fill code in place, and with proper
documentation
to let the user know that (1) we will auto-fill the NUMA cpus up to the
number to maximum VCPUs number if QEMU supports it and (2) the user
is advised to always supply a complete NUMA topology, this warning
is unneeded.
This reverts commit 38d2e033686b5cc274f8f55075ce1985b71e329a.
Since we already have the validation in place for some time now I think
we should just keep it. The auto-filling would be a useful hack to work
around if config breaks, but judged by itself it's of questionable
benefit.
Specifically users might end up with a topology which they didn't
expect. Reasoning is basically the same as with qemu. Any default
behaviour here is a policy decision and it might not suit all uses.