Re: [libvirt] [PATCH 09/21] qemu_hotplug: merge qemuDomainDetachThisHostDevice into qemuDomainDetachHostDevice

On Thu, Mar 21, 2019 at 18:28:49 -0400, Laine Stump wrote: > It's now only called from one place, and combining the two functions > highlights the similarity with Detach functions for other device > types. > > Signed-off-by: Laine Stump <laine(a)laine.org&gt; > --- > src/qemu/qemu_hotplug.c | 107 +++++++++++++++------------------------- > 1 file changed, 41 insertions(+), 66 deletions(-) ACK, this does what it says. There are a few things that could be done better though e.g. assigning an alias via qemuAssignDeviceHostdevAlias makes the chechk whether it's assigned dead code.