Re: [libvirt] [PATCH v3 3/9] qemu: Implement the qemu driver fetch for IOThreads

>> + for (i = 0; i < targetDef->iothreads; i++) { >> + if (VIR_ALLOC(info_ret[i]) < 0) >> + goto cleanup; >> + >> + /* IOThreads being counting at 1 */ >> + info_ret[i]->iothread_id = i + 1; >> + >> + if (VIR_ALLOC_N(info_ret[i]->cpumap, maplen) < 0) >> + goto cleanup; >> + >> + /* Initialize the cpumap */ >> + info_ret[i]->cpumaplen = maplen; >> + memset(info_ret[i]->cpumap, 0xff, maplen); >> + if (maxcpu % 8) >> + info_ret[i]->cpumap[maplen - 1] &= (1 << maxcpu % 8) - 1; > > virBitmapToData could make this more readable. > This is where I'm not sure varying from the existing API's model w/r/t cpumap & maplen, etc. should be done..

>> + } >> + >> + /* If iothreadspin setting exists, there are unused physical cpus */ >> + iothreadspin_list = targetDef->cputune.iothreadspin; > > A temporary variable pointing to iothreadspin[i] is more common. > straight copy of qemuDomainGetVcpuPinInfo