Re: [libvirt] [PATCH] virsh: Allow users to reedit rejected XML

I agree that the code should only be there once, but rather than creating all the other versions with a strange sed script in the makefile, I think the correct solution is the more usual/accepted method of making a generic helper function that parameterizes everything that is different between the different types of edit, with a short function for each version that calls this helper function. (I have this bad feeling that I once promised to do that, but then forgot and never made good on my promise :-/) (or alternately, doing it with a macro as Dan suggests. That makes for a pretty long macro, though :-)