Re: [libvirt] [PATCH] Eliminate noise from python type wrappers
On Tue, Jun 24, 2008 at 03:57:21PM -0700, Ryan Scott wrote:
Hi,
We recently had a virt-install build failure when someone tried
building on a system with debug libvirt packages installed. It was
caused by extra noise from commands that load libvirt. For example:
$ python ./setup.py --version
libvirt_virConnectPtrWrap: node = 8938fb8
0.300.3
I've seen (internal) complaints about this, and I think the
irritation from the noise outweighs the usefulness of these statements,
so they should be removed.
ACK, gets my vote. We really don't need this debug info from the data
type convertors. All the public APIs already print out their args when
LIBVIRT_DEBUG=1 is set.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|