Re: [Libvir] [PATCH] Useless statement in openvzGetVPSInfo
On Thu, Feb 21, 2008 at 08:59:01PM +0300, Anton Protopopov wrote:
Hi,
the patch is now in attachement..
I think, that the statement
if (!vm)
vm = *pnext;
will never be executed: in the first pass, we have already check this
a few lines before; in next passes, vm remains the same...
Anton
Hum, that doesn't match what I see. vm is initialized to NULL on entry
and no changed before the loop, so on first iteration of the loop vm is
set using that code.
I don't understand the logic of your patch,
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/